[Fleet] Adjust add integration flow #101714

jloleysens · 2021-06-09T08:30:09Z

Summary

Link to integrations UI instead of add integration flow in fleet
Added route state for "current policy" that is forwarded to integrations, then sent back to fleet
After adding the integration in fleet, the user is sent to the agent policy details view instead of back to integration details

How to test

Start Kibana + ES on basic
Follow the in-app instructions for setting up a fleet server where agents can be registered
Go to "fleet"
View the available Indicate managed ILM policies in the UI #101438
Go to a specific policy
Click the "Add integration" button
Select an integration package (you should be in the integrations UI)
On clicking "Add {package name}" you should be directed to the fleet create package screen with first step "Configure" and second step select policy, with your policy name preconfigured
Redirects:

Cancel: should take you back to the policy details view
Saving: should take you back to the policy details view with a toast asking you to add the policy to an agent

Screenshots

Redesigned add to policy step:

Just before choosing a package, we might consider this for a future update:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

Risk Matrix

Risk	Probability	Severity	Mitigation/Notes
Refactor of existing behaviour	Med	Med	Careful CR, review with stakeholders and updating automated testing

- added link to the integrations UI instead of add integration in fleet - added a new piece of route state that gets passed to integration from fleet when browsing integrations for a policy - when the integration is being added the page will send the user back to the policy overview instead of back to integrations UI

jloleysens · 2021-06-09T08:34:49Z

@elasticmachine merge upstream

jloleysens · 2021-06-09T09:24:43Z

@elasticmachine merge upstream

jloleysens · 2021-06-10T09:43:40Z

@elasticmachine merge upstream

kibanamachine · 2021-06-10T09:43:41Z

merge conflict between base and head

…add-integrations-redirect * 'master' of github.com:elastic/kibana: (44 commits) Allow navigating discover flyout via arrow keys (elastic#101772) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) ... # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx

… page

elasticmachine · 2021-06-10T16:03:48Z

Pinging @elastic/fleet (Team:Fleet)

kpollich

LGTM! No issues with code from me, and the intra-app state seems to work well. Awesome work 🚀

jen-huang

I did a quick test locally with granular integrations and it works really nicely with that too! Left a small comment but otherwise LGTM 🚀

jen-huang · 2021-06-10T17:12:45Z

...s/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx

@@ -459,7 +451,8 @@ export const CreatePackagePolicyPage: React.FunctionComponent = () => {
          )}
      <StepsWithLessPadding steps={steps} />
      <EuiSpacer size="l" />
-      <EuiBottomBar>
+      {/* Note: we set a relatively _low_ zIndex value here to account for EuiComboBox popover that might appear under the bottom bar */}
+      <EuiBottomBar style={{ zIndex: 50 }}>


nit: can we use styled instead of this inline style?

jloleysens · 2021-06-14T08:19:31Z

@elasticmachine merge upstream

…be obstructing content

kibanamachine · 2021-06-14T17:29:14Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1006	1007	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	710.7KB	706.2KB	-4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	434.8KB	435.5KB	+688.0B

Unknown metric groups

API count

id	before	after	diff
`fleet`	1096	1098	+2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

dmlemeshko

Code LGTM

* Initial commit, very WIP - added link to the integrations UI instead of add integration in fleet - added a new piece of route state that gets passed to integration from fleet when browsing integrations for a policy - when the integration is being added the page will send the user back to the policy overview instead of back to integrations UI * remove unnecessary agent policy clear function * added # to path so that navigation is correctly handled * added logic to read the forward agent policy id * remove inline select integration package from fleet add integration * updated toast notification * using query parameter to pass policy id back to create policy package page * removed policyId from route path * fix type issue * updated the select agent field layout per the designs * simpified item rendering in combobox and fixed combobox z-index issue * added comment * fix types and i18n * updated icon and removed unused i18n * refactor to using styled components for cusomt z-index styling * attempt to fix integration test * added scroll functionality for dealing with fixed footers that might be obstructing content * fix scroll direction! * attempting another scroll algorithm Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-06-15T07:29:20Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Initial commit, very WIP - added link to the integrations UI instead of add integration in fleet - added a new piece of route state that gets passed to integration from fleet when browsing integrations for a policy - when the integration is being added the page will send the user back to the policy overview instead of back to integrations UI * remove unnecessary agent policy clear function * added # to path so that navigation is correctly handled * added logic to read the forward agent policy id * remove inline select integration package from fleet add integration * updated toast notification * using query parameter to pass policy id back to create policy package page * removed policyId from route path * fix type issue * updated the select agent field layout per the designs * simpified item rendering in combobox and fixed combobox z-index issue * added comment * fix types and i18n * updated icon and removed unused i18n * refactor to using styled components for cusomt z-index styling * attempt to fix integration test * added scroll functionality for dealing with fixed footers that might be obstructing content * fix scroll direction! * attempting another scroll algorithm Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>

* Initial commit, very WIP - added link to the integrations UI instead of add integration in fleet - added a new piece of route state that gets passed to integration from fleet when browsing integrations for a policy - when the integration is being added the page will send the user back to the policy overview instead of back to integrations UI * remove unnecessary agent policy clear function * added # to path so that navigation is correctly handled * added logic to read the forward agent policy id * remove inline select integration package from fleet add integration * updated toast notification * using query parameter to pass policy id back to create policy package page * removed policyId from route path * fix type issue * updated the select agent field layout per the designs * simpified item rendering in combobox and fixed combobox z-index issue * added comment * fix types and i18n * updated icon and removed unused i18n * refactor to using styled components for cusomt z-index styling * attempt to fix integration test * added scroll functionality for dealing with fixed footers that might be obstructing content * fix scroll direction! * attempting another scroll algorithm Co-authored-by: Kibana Machine <[email protected]>

jloleysens added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 9, 2021

jloleysens requested a review from kpollich June 9, 2021 08:30

Merge branch 'master' into fleet/adjust-add-integrations-redirect

e366d00

kibanamachine and others added 6 commits June 9, 2021 05:24

Merge branch 'master' into fleet/adjust-add-integrations-redirect

7802361

remove unnecessary agent policy clear function

03fe7b1

added # to path so that navigation is correctly handled

af3172d

added logic to read the forward agent policy id

8edb789

remove inline select integration package from fleet add integration

e1708bf

updated toast notification

3a05899

jloleysens added 5 commits June 10, 2021 12:18

using query parameter to pass policy id back to create policy package…

bc88a5f

… page

removed policyId from route path

b08fdd9

fix type issue

67edafe

updated the select agent field layout per the designs

bdbce4d

jloleysens mentioned this pull request Jun 10, 2021

[EuiComboBox] Combobox popover can be hidden behind EuiBottomBar elastic/eui#4872

Closed

jloleysens added 3 commits June 10, 2021 17:55

simpified item rendering in combobox and fixed combobox z-index issue

1c22dfd

added comment

7021bfb

fix types and i18n

6e64190

jloleysens marked this pull request as ready for review June 10, 2021 16:03

jloleysens requested a review from a team as a code owner June 10, 2021 16:03

updated icon and removed unused i18n

91878bd

jen-huang assigned jloleysens Jun 10, 2021

kpollich approved these changes Jun 10, 2021

View reviewed changes

jen-huang approved these changes Jun 10, 2021

View reviewed changes

kibanamachine and others added 4 commits June 14, 2021 04:19

Merge branch 'master' into fleet/adjust-add-integrations-redirect

114444e

refactor to using styled components for cusomt z-index styling

546a0fa

attempt to fix integration test

5001d92

added scroll functionality for dealing with fixed footers that might …

5d49fd4

…be obstructing content

jloleysens requested a review from a team as a code owner June 14, 2021 12:40

jloleysens added 2 commits June 14, 2021 14:42

fix scroll direction!

e6cf34f

attempting another scroll algorithm

28f1f2a

dmlemeshko approved these changes Jun 14, 2021

View reviewed changes

jloleysens merged commit f70542a into elastic:master Jun 15, 2021

jloleysens deleted the fleet/adjust-add-integrations-redirect branch June 15, 2021 07:26

kibanamachine mentioned this pull request Jun 15, 2021

[7.x] [Fleet] Adjust add integration flow (#101714) #102152

Merged

jloleysens mentioned this pull request Jun 24, 2021

[Fleet] UI jumps when selecting an agent policy #103230

Closed

kpollich mentioned this pull request Jul 1, 2021

[Integrations UI] Search integrations for all substrings + don't search on description #104099

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Adjust add integration flow #101714

[Fleet] Adjust add integration flow #101714

jloleysens commented Jun 9, 2021 •

edited

Loading

jloleysens commented Jun 9, 2021

jloleysens commented Jun 9, 2021

jloleysens commented Jun 10, 2021

kibanamachine commented Jun 10, 2021

elasticmachine commented Jun 10, 2021

kpollich left a comment

jen-huang left a comment

jen-huang Jun 10, 2021

jloleysens commented Jun 14, 2021

kibanamachine commented Jun 14, 2021

API count

dmlemeshko left a comment

kibanamachine commented Jun 15, 2021

[Fleet] Adjust add integration flow #101714

[Fleet] Adjust add integration flow #101714

Conversation

jloleysens commented Jun 9, 2021 • edited Loading

Summary

How to test

Screenshots

Checklist

Risk Matrix

jloleysens commented Jun 9, 2021

jloleysens commented Jun 9, 2021

jloleysens commented Jun 10, 2021

kibanamachine commented Jun 10, 2021

elasticmachine commented Jun 10, 2021

kpollich left a comment

Choose a reason for hiding this comment

jen-huang left a comment

Choose a reason for hiding this comment

jen-huang Jun 10, 2021

Choose a reason for hiding this comment

jloleysens commented Jun 14, 2021

kibanamachine commented Jun 14, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

dmlemeshko left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 15, 2021

💚 Backport successful

jloleysens commented Jun 9, 2021 •

edited

Loading